feat: allow passing DBCreateOptions to IdbStorage constructor
#850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krpeacock
requested changes
Feb 21, 2024
There was a problem hiding this comment.
Suggestions:
- prefer private properties over typescript
privatekeyword - JSDocs for constructor
Co-authored-by: Kai Peacock <kylpeacock@gmail.com>
Co-authored-by: Kai Peacock <kylpeacock@gmail.com>
# Conflicts: # docs/generated/changelog.html
Nice! I'd never come across these before. I've merged in your suggestions. |
krpeacock
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Each
IdbStorageinstance wraps anIdbKeyValinstance which itself can be configured via theDBCreateOptions.Prior to this PR there are no configuration options when creating
IdbStorageinstances.This PR makes it such that
IdbStorageinstances can optionally be configured by passingDBCreateOptionsin the constructor which will feed through to the innerIdbKeyVal.How Has This Been Tested?
It has only been tested via the automated tests.
Checklist: