feat: replay attack prevention using watermarks #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inity/agent-js into kai/SDK-1332-prevent-outdated-queries
size-limit report 📦
|
chmllr
approved these changes
Mar 13, 2024
dfx-json
reviewed
Mar 13, 2024
| value: jest.fn(), | ||
| Object.defineProperty(global, 'console', { | ||
| writable: true, | ||
| value: { ...global.console, log: jest.fn(), warn: jest.fn(), error: jest.fn() }, |
There was a problem hiding this comment.
does this mean that no logs will be printed during test execution?
There was a problem hiding this comment.
Yes, it's to clean up the console by default when running the tests. However, the logs aren't lost and you can access them as needed
dfx-json
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several reports have been received about an issue affecting how immediately a response from an update call can be used. One example is the following scenario:
an update call is made to create a new resource (e.g. a social media post)
the application navigates to a page that displays the resource (e.g. the post itself)
the application requests the resource by executing a query call and using the resource id
the query hits a replica whos state has not yet been updated
a 404 is returned
the problem is, the resource does exist, it just so happens that 1/3 of replicas may not necessarily be up to date at the same moment the other 2/3’s are
Fixes # SDK-1332
How Has This Been Tested?
New unit and end to end tests, introducing a replay attack test in
e2e/node/basic/watermark.test.tsChecklist: