fix: Work around credentials not being enumerable #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an issue that arises from assuming that the `PublicKeyCredential` returned from `navigators.credentials.create` is enumerable.
| @@ -112,7 +112,12 @@ async function _createCredential( | |||
| } | |||
|
|
|||
| return { | |||
| ...creds, | |||
| // do _not_ use ...creds here, as creds is not enumerable in all cases | |||
There was a problem hiding this comment.
@krpeacock: Isn't there any Typescript feature that would these types of issues (trying to spread non-enumerable objects)?
There was a problem hiding this comment.
Anything that extends a class, Record or object will inherit the Iterable trait. If the browser is not allowing us to spread fields from the creds response, there is an issue with the TypeScript-provided dom types
krpeacock
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue that arises from assuming that the
PublicKeyCredentialreturned fromnavigators.credentials.createis enumerable.How Has This Been Tested?
Manual testing.
Checklist: