Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replaces global npm install with setup-node #875

Merged
merged 1 commit into from
Apr 25, 2024
Merged

chore: replaces global npm install with setup-node #875

merged 1 commit into from
Apr 25, 2024

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Apr 25, 2024 •
edited

Description

replaces globle npm install with setup-node because of a bug that started happening recently

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner April 25, 2024 16:48
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@dfinity/agent 84.83 KB (0%)
@dfinity/candid 13.58 KB (0%)
@dfinity/principal 4.97 KB (0%)
@dfinity/auth-client 59.87 KB (0%)
@dfinity/assets 79.54 KB (0%)
@dfinity/identity 57.16 KB (0%)
@dfinity/identity-secp256k1 281.23 KB (0%)

@krpeacock krpeacock enabled auto-merge (squash) April 25, 2024 16:52
@krpeacock krpeacock disabled auto-merge April 25, 2024 16:53
@krpeacock krpeacock enabled auto-merge (squash) April 25, 2024 16:53
@krpeacock krpeacock changed the title chore: replaces globle npm install with setup-node chore: replaces global npm install with setup-node Apr 25, 2024
@krpeacock krpeacock merged commit 0fb4196 into main Apr 25, 2024
70 checks passed
@krpeacock krpeacock deleted the kai/size-action branch April 25, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwshang lwshang lwshang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krpeacock @lwshang