fix: update certificate checking if disable_range_check is set #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
requested changes
Aug 26, 2022
Co-authored-by: Eric Swanson <64809312+ericswanson-dfinity@users.noreply.github.com>
mraszyk
commented
Aug 30, 2022
mraszyk
changed the title
|
@mraszyk any chance you can document this code better somehow? I have a really hard time understanding what happens for what reason |
sesi200
approved these changes
Sep 9, 2022
ericswanson-dfinity
requested changes
Sep 14, 2022
| for p in paths { | ||
| if !(p == vec![t.clone()] || p[0] == rs) { | ||
| // the path has neither the form /time nor /request_status/* | ||
| return Err(AgentError::CertificateVerificationFailed()); |
There was a problem hiding this comment.
Up until now, the CertificateVerificationFailed error referred to a specific cause: bls::core_verify() returned something other than BLS_OK, meaning the certificate signature didn't match the expected value.
I think it would be helpful to someone diagnosing these errors if we introduced a new error type, CertificateVerificationRejected(reason), where reason is an enumeration that gives more information about the reason for the rejection of the certificate. What do you think?
|
Superseded by this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
disable_range_checkcondition should check that the call is to the Management Canister, not to an application canister offering a method with the nameprovisional_canister_create_with_cycles.Moreover, the certification validation should follow the updated Interface Spec.