fix: disallow sharing of memo table in IDLBuilder #210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a global memo table to map Rust type to Candid type. The same Rust type can map to a different but equivalent Candid type in different runs, due to memo match happen in different time/order. Unless we implement equivalence checking for candid types, we failed to identify these equivalent types in the type table.
The fix is easy: disallow sharing of memo tables across different encoding calls.