New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort define_service #441

Merged

chenyan-dfinity merged 2 commits into master from sort-service

Jun 30, 2023

Contributor

chenyan-dfinity commented Jun 29, 2023

Fix #438


          sort define_service

bba32d2

github-actions bot commented Jun 29, 2023

Benchmark for `92395ae`

Click to view benchmark

Test	Base	PR	%
Blob/&str	216.3±130.92µs	209.4±119.15µs	-3.19%
Blob/ByteBuf	136.2±50.40µs	135.5±48.86µs	-0.51%
Blob/Bytes	104.2±46.71µs	102.1±46.64µs	-2.02%
Blob/String	249.5±130.61µs	243.3±128.97µs	-2.48%
Collections/vec (text, nat)	65.0±0.56ms	65.4±0.85ms	+0.62%
Collections/vec int	30.2±0.06ms	30.5±0.07ms	+0.99%
Collections/vec int64	16.2±0.10ms	16.5±0.22ms	+1.85%
Collections/vec nat8	13.3±0.02ms	13.1±0.03ms	-1.50%
option list/1024	1336.6±2.38µs	1339.0±2.21µs	+0.18%
profiles/1024	2.5±0.00ms	2.6±0.03ms	+4.00%
variant list/1024	1087.5±1.87µs	1084.3±2.90µs	-0.29%

kentosugama approved these changes

View reviewed changes

chenyan-dfinity added the automerge-squash label


          Merge branch 'master' into sort-service

b233a60

github-actions bot commented Jun 30, 2023

Benchmark for `4918144`

Click to view benchmark

Test	Base	PR	%
Blob/&str	193.8±65.95µs	193.1±65.00µs	-0.36%
Blob/ByteBuf	138.5±49.80µs	135.3±49.75µs	-2.31%
Blob/Bytes	98.7±34.57µs	97.8±35.32µs	-0.91%
Blob/String	212.7±74.70µs	213.0±74.25µs	+0.14%
Collections/vec (text, nat)	66.8±1.02ms	65.2±0.70ms	-2.40%
Collections/vec int	30.3±0.31ms	30.1±0.07ms	-0.66%
Collections/vec int64	16.0±0.18ms	16.4±0.15ms	+2.50%
Collections/vec nat8	13.1±0.02ms	13.2±0.02ms	+0.76%
option list/1024	1340.9±14.47µs	1335.7±1.87µs	-0.39%
profiles/1024	2.5±0.00ms	2.6±0.00ms	+4.00%
variant list/1024	1086.6±1.42µs	1087.1±4.28µs	+0.05%

chenyan-dfinity merged commit f1d573c into master

4 checks passed

chenyan-dfinity deleted the sort-service branch

June 30, 2023 19:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment