Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(registry-dump): Interpret vec<u8> data in registry structs as corresponding types #175

Merged
merged 2 commits into from
Feb 9, 2024
Merged

feat(registry-dump): Interpret vec<u8> data in registry structs as corresponding types #175

merged 2 commits into from
Feb 9, 2024

Conversation

sasa-tomic
Copy link
Member

  • Instead of expecting from the user to interpret Vec as principals (somehow), we can do this in the code directly, and show principals as principals
  • Make the dump more in line with what ic-admin shows (in ic-admin get-topology)
  • Show the node reward table as well
  • Use native JSON serialize for the dump, instead of manually crafting the wrapper struct
  • Use the same dir that the registry sync uses, to avoid the slow re-downloading the entire mainnet registry on every execution

@sasa-tomic
feat(registry-dump): Interpret vec<u8> data in registry structs as co…
8c55f06 
…rresponding types

- Instead of expecting from the user to interpret Vec<u8> as principals (somehow), we can do this in the code directly, and show principals as principals
- Make the dump more in line with what ic-admin shows (in ic-admin get-topology)
- Show the node reward table as well
- Use native JSON serialize for the dump, instead of manually crafting the wrapper struct
- Use the same dir that the registry sync uses, to avoid the slow re-downloading the entire mainnet registry on every execution
@sasa-tomic sasa-tomic requested a review from a team as a code owner February 9, 2024 08:37
NikolaMilosa
NikolaMilosa approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@NikolaMilosa NikolaMilosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@sasa-tomic sasa-tomic added this pull request to the merge queue Feb 9, 2024
Merged via the queue into main with commit 3be2000 Feb 9, 2024
4 checks passed
@sasa-tomic sasa-tomic deleted the sat-dre-cli-registry-dump-interpret branch February 9, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolaMilosa NikolaMilosa NikolaMilosa approved these changes

@pietrodimarco-dfinity pietrodimarco-dfinity pietrodimarco-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sasa-tomic @NikolaMilosa @pietrodimarco-dfinity