Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup release index #388

Closed
wants to merge 1 commit into from
Closed

Cleanup release index #388

wants to merge 1 commit into from

Conversation

LittleChimera
Copy link
Contributor

No description provided.

@LittleChimera LittleChimera requested a review from a team as a code owner May 17, 2024 13:17
NikolaMilosa
NikolaMilosa approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@NikolaMilosa NikolaMilosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

DFINITYManu
DFINITYManu requested changes May 17, 2024
View reviewed changes
Copy link
Contributor

@DFINITYManu DFINITYManu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? no need to delete old records, no? if the software has a bug, the software should be fixed.

DFINITYManu
DFINITYManu approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@DFINITYManu DFINITYManu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contingent on this not becoming something any of us has to do periodically.

@sasa-tomic
Copy link
Member

Actually seems like the unassigned nodes did not get updated as they should have been and therefore we had old revisions being "active" and constantly rechecked.
Instead of merging this PR we should probably fix the regular updates of the unassigned nodes. There is now a separate proposal that we can vote in, that updates unassigned nodes. It will be used by default in the DRE tool once #411 is merged.

@sasa-tomic sasa-tomic closed this May 23, 2024
@sasa-tomic sasa-tomic deleted the cleanup-release-index2 branch June 21, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolaMilosa NikolaMilosa NikolaMilosa approved these changes

@DFINITYManu DFINITYManu DFINITYManu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LittleChimera @sasa-tomic @NikolaMilosa @DFINITYManu