Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update all motoko examples to use v0.6.10 version of dfx #52

Merged
merged 12 commits into from
Oct 6, 2020

Conversation

andrewwylde
Copy link
Contributor

Major breaking change in Motoko meant that all typings need to exist inside of the actors, and I figured I'd pin each example to a version to make sure folks know they're running the right dfx. Verified each of these locally to make sure things built and UIs were updated to the current best practice pattern (i.e. asset canisters).

motoko/simple_to_do/test.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this

Co-authored-by: Claudio Russo <claudio@dfinity.org>
@andrewwylde andrewwylde merged commit fe3ed89 into master Oct 6, 2020
@andrewwylde andrewwylde deleted the aw/fix/motoko-examples branch October 6, 2020 19:56
@miguelemosreverte
Copy link

miguelemosreverte commented Oct 6, 2020

this fixes Issue #51, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants