feat: set transitions as local #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Jul 12, 2023
# Motivation Svelte transitions are executed by default in components regardless if their parent components destroy those or not. This behavior is known as the `|global` transitions. This leads NNS dapp to various issues in which components are not destroyed and therefore, there context remains active. Until today we solved this by applying a workaround in which we destroyed the all layout in case of navigation. While it solved the issue, this had for side effect to be a bit unpleasant for the eyes as the all page layout disappeared on navigation. By setting all the animation to `|local` we can solve the issue and make the navigation more fluid. # References - documentation: https://svelte.dev/docs/v4-migration-guide#transitions-are-local-by-default - svelte issue: sveltejs/svelte#6686 # PRs - [x] dfinity/gix-components#246 # Previous issues - #1741 - #2861 # Changes - update gix-cmp to set `|local` to any Svelte transitions - set `|local` to the Svelte animations implemented in NNS dapp - remove detail page layout navigating guard # Notes In the login page we will continue to observe `$navigating` because this condition was not only used to solve the issue but, also to present a spinner while the application is loading.
peterpeterparker
pushed a commit
that referenced
this pull request
Jul 13, 2023
# Motivation Set svelte animation `local` to `global` because of broken `introend` event. # PRs - Revert #246 # Changes - local to global everywhere # Screenshots No visual changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Svelte transitions are executed by default in components regardless if their parent components destroy those or not. This behavior is known as the
|globaltransitions setting and is the default in Svelte v3.This leads to issue with the SvelteKit navigation because DOM elements might not be detached and related context might remain active.
We generally notice the issue in NNS dapp after navigation when the DOM wrongly contains two
split-paneelements.In Svelte v4 the default behavior was changed to
|local. Setting that can already be used in v3 when explicitely set. This setting has for effect to not execute the transition and destroy the components if parents destroy those. i.e. to populate the destroy.References
Changes
|local