Radio toggle component #387
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/gix-components into labeled-toggle-component # Conflicts: # src/routes/(split)/components/radio-toggle/+page.md
|
Can we perhaps use 
|
Perhaps we could, but this means to support 2 different themes for the component with different styles / widths. 
Let me evaluate it. |
|
I think we should be careful about adding new design elements every time we add a new feature and try to reuse components as much as possible. Would be could if you could check with PM/UX if this can be reused. Maybe by adjusting either the existing component or the new feature. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A radio group component to be used first on the proposals page.
Changes
RadioTogglecompoentTest
RadioToggleScreenshots