Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: modal lint error #422

Merged
merged 2 commits into from May 13, 2024
Merged

chore: modal lint error #422

merged 2 commits into from May 13, 2024

Conversation

peterpeterparker
Copy link
Member

Motivation

Fix lint error:

/Users/daviddalbusco/projects/dfinity/gix-components/src/lib/components/Modal.svelte:35:28
Error: Binding element 'key' implicitly has an 'any' type. (ts)

const handleKeyDown = ({ key }) => {
// Check for $busy to mock the same behavior as the close button being covered by the busy overlay

dskloetd
dskloetd approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@dskloetd dskloetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterpeterparker peterpeterparker removed the request for review from mstrasinskis May 13, 2024 04:21
@peterpeterparker peterpeterparker merged commit 00a6efe into main May 13, 2024
8 checks passed
@peterpeterparker peterpeterparker deleted the chore/lint-modal branch May 13, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterpeterparker @dskloetd