Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update ic-mgmt candid and log_visibility support #638

Merged
merged 5 commits into from
May 27, 2024

Conversation

peterpeterparker
Copy link
Member

Motivation

Updating the log_visibility Candid types as provided by the weekly batch (PR #633) requires also adapting the function to update_settings accordingly.

Changes

  • update Candid types as in Update Candid Files #633
  • add log_visibility to mock data
  • create new enum LogVisibility (same pattern as InstallCode)
  • extend function toCanisterSettings to map the log visibility

Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker peterpeterparker mentioned this pull request May 27, 2024
1 task
Copy link
Contributor

github-actions bot commented May 27, 2024

size-limit report 📦

Path Size
@dfinity/ckbtc 7.24 KB (0%)
@dfinity/cketh 3.44 KB (0%)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 3.6 KB (0%)
@dfinity/ledger-icp 14.72 KB (0%)
@dfinity/nns 34.58 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 15.72 KB (0%)
@dfinity/utils 4.47 KB (0%)
@dfinity/ic-management 2.83 KB (+6.63% 🔺)

Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker peterpeterparker merged commit fbda59a into main May 27, 2024
11 checks passed
@peterpeterparker peterpeterparker deleted the feat/ic-mgmt-candid-log-visibility branch May 27, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants