Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expose icrc1 types in ICP lib #647

Merged
merged 2 commits into from
Jun 3, 2024
Merged

fix: expose icrc1 types in ICP lib #647

merged 2 commits into from
Jun 3, 2024

Conversation

peterpeterparker
Copy link
Member

Motivation

When I added the missing Icrc2ApproveRequest interface for the PR I provided recently, I noticed that actually other Icrc types of the @dfinity/ledger-icp were not exposed.

Changes

  • Expose missing types which are using in functions' parameters.

@peterpeterparker
fix: expose icrc1 types in ICP lib
7540dcd 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 7.27 KB (0%)
@dfinity/cketh 3.49 KB (0%)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 3.64 KB (0%)
@dfinity/ledger-icp 15.22 KB (0%)
@dfinity/nns 34.62 KB (+0.01% 🔺)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 15.72 KB (0%)
@dfinity/utils 4.47 KB (0%)
@dfinity/ic-management 2.83 KB (0%)

@peterpeterparker peterpeterparker merged commit 956c57a into main Jun 3, 2024
11 checks passed
@peterpeterparker peterpeterparker deleted the fix/expose-icrc1-types branch June 3, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterpeterparker @lmuntaner