Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --silent to npm pack #668

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Add --silent to npm pack #668

merged 4 commits into from
Jul 1, 2024

Conversation

lmuntaner
Copy link
Contributor

Motivation

@frederikrothenberger discovered that the outupt of npm pack is different depending on the npm version.

Later versions of npm output some commands. Adding --silent ensures that the output is a valid JSON without the commands.

Changes

  • Add --silent to publish-npm.sh.

Tests

Tested manually.

Todos

  • Add entry to changelog (if necessary). NOT necessary.

@lmuntaner lmuntaner requested review from a team as code owners July 1, 2024 08:30
@lmuntaner
Copy link
Contributor Author

@dskloetd @peterpeterparker please review

Copy link
Contributor

github-actions bot commented Jul 1, 2024

size-limit report 📦

Path Size
@dfinity/ckbtc 7.91 KB (0%)
@dfinity/cketh 3.56 KB (0%)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 3.88 KB (0%)
@dfinity/ledger-icp 15.22 KB (0%)
@dfinity/nns 34.88 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 15.71 KB (0%)
@dfinity/utils 4.47 KB (0%)
@dfinity/ic-management 2.78 KB (0%)

Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@dskloetd
Copy link
Collaborator

dskloetd commented Jul 1, 2024

Are you sure those commands aren't output on stderr instead of stdout? Not outputing JSON when --json is passed sounds like a major bug. Was it reported back to them?

@lmuntaner
Copy link
Contributor Author

Are you sure those commands aren't output on stderr instead of stdout? Not outputing JSON when --json is passed sounds like a major bug. Was it reported back to them?

We found an issuer reporting it, and they considered it as fixed with the --silent flag.

npm/cli#7354

@lmuntaner lmuntaner enabled auto-merge (squash) July 1, 2024 15:50
@lmuntaner lmuntaner merged commit 941864e into main Jul 1, 2024
11 checks passed
@lmuntaner lmuntaner deleted the lm-add-silent-npm-pack branch July 1, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants