Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motoko playground redirection #16

Merged
merged 17 commits into from
Aug 10, 2022
Merged

Motoko playground redirection #16

merged 17 commits into from
Aug 10, 2022

Conversation

kentosugama
Copy link
Contributor

No description provided.

@kentosugama kentosugama requested a review from a team as a code owner July 11, 2022 20:39
src/bin/main.rs Outdated Show resolved Hide resolved
src/limit_resource.rs Outdated Show resolved Hide resolved
src/limit_resource.rs Show resolved Hide resolved
tests/deployable.ic-repl.sh Outdated Show resolved Hide resolved
tests/deployable.ic-repl.sh Show resolved Hide resolved
@@ -43,7 +43,7 @@ enum SubCommand {
#[clap(short, long)]
limit_stable_memory_page: Option<u32>,
/// Redirects create_canister system API calls to specified motoko backend canister ID
#[clap(short('R'), long)]
#[clap(short, long)]
playground_backend_redirect: Option<ic_types::Principal>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are actually quite close to have a generic redirection feature, i.e., redirect any inter-canister call to another canister. But let's focus on the current version e2e before making it more general.

@kentosugama kentosugama merged commit 2e876e8 into main Aug 10, 2022
@kentosugama kentosugama deleted the reuse-canister branch August 10, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants