Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adopt to new meter, streaming __get_profiling #41

Merged
merged 20 commits into from
Oct 11, 2023
Merged

adopt to new meter, streaming __get_profiling #41

merged 20 commits into from
Oct 11, 2023

Conversation

chenyan-dfinity
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity commented Aug 29, 2023 •
edited
Loading

  • bug fix to always allocate 2M heap memory in __get_profiling
  • use-new-metering flag
  • streaming __get_profiling

@chenyan-dfinity chenyan-dfinity requested a review from a team as a code owner August 29, 2023 20:00
@chenyan-dfinity chenyan-dfinity marked this pull request as draft August 31, 2023 00:33
@chenyan-dfinity chenyan-dfinity changed the title adopt to new meter adopt to new meter, streaming __get_profiling Oct 9, 2023
crusso
crusso approved these changes Oct 10, 2023
View reviewed changes
Copy link

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(rubberstamping)

@chenyan-dfinity chenyan-dfinity marked this pull request as ready for review October 11, 2023 02:00
@chenyan-dfinity chenyan-dfinity requested a review from a team as a code owner October 11, 2023 02:00
@chenyan-dfinity chenyan-dfinity merged commit a2ceb43 into main Oct 11, 2023
3 checks passed
@chenyan-dfinity chenyan-dfinity deleted the new-meter branch October 11, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crusso crusso crusso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chenyan-dfinity @crusso