Skip to content

Commit

Permalink
Merge branch 'andriy/run-871-simplify-tests' into 'master'
Browse files Browse the repository at this point in the history
chore: RUN-871: Simplify query cache tests

This MR addresses minor query cache post-review comments and significantly reduces number of code lines in tests (from 1509 to 999).

The main points to reduce the number of code lines:

1. Use one-line test builders, i.e. `builder_with_query_cache_max_expiry_time()`
2. Use `test.non_replicated_query()` instead of `test.query()`
3. Use a dedicated metrics getter `query_cache_metrics(&test)`
4. Use shorter names, so asserts fit into a single line.

The number of tests and their functionality remains the same, so it's a chore.

Closes RUN-871 

Closes RUN-871

See merge request dfinity-lab/public/ic!16802
  • Loading branch information
dfinity-berestovskyy committed Dec 19, 2023
2 parents e623b14 + 0fbc85c commit 7373766
Show file tree
Hide file tree
Showing 3 changed files with 529 additions and 1,039 deletions.

0 comments on commit 7373766

Please sign in to comment.