Skip to content

Commit

Permalink
Merge branch 'jason/NNS1-2718' into 'master'
Browse files Browse the repository at this point in the history
feat(ic-admin): NNS1-2718 Change both RegistryCanister and RegistryClientImpl check responses against nns public key

Overall, the response checking is enabled if (a) ic-admin is pointed to mainnet, or (b) `verify-nns-responses=true` and a key file is given (the logic is refactored to a function `parse_nns_public_key`.

3 major changes:
1. RegistryCanister now uses an agent with nns_public_key similar to when ic-admin calls other canisters.
2. RegisterClientImpl now uses CertifiedNnsDataProvider which calls a certified endpoint with an update call.
3. Change IC_DOMAIN to IC_DOMAINS to cover more cases for nns-url param.

Closes NNS1-2718 

Closes NNS1-2718

See merge request dfinity-lab/public/ic!17253
  • Loading branch information
jasonz-dfinity committed Jan 22, 2024
2 parents af3e872 + bc046ff commit c8be7bd
Show file tree
Hide file tree
Showing 2 changed files with 192 additions and 89 deletions.

0 comments on commit c8be7bd

Please sign in to comment.