Decouple clean build CI job from prod build #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR splits the canister_tests clean build CI job into two parts: the clean build & the hash check. This allows to start the clean build immediately instead of just after the prod build. Also, the clean build now really builds the prod build from scratch, including the dev build that's hashed into it due to dfx deps (if applicable, i.e. only release builds).
frederikrothenberger
force-pushed
the
frederik/reorder-clean-build
branch
from
6a9bc9a
to
3082c22
Compare
frederikrothenberger
force-pushed
the
frederik/reorder-clean-build
branch
from
3082c22
to
282d8b3
Compare
| @@ -70,7 +70,6 @@ jobs: | |||
|
|
|||
| # Since the release build check is a scheduled job, a failure won't be shown on any | |||
| # PR status. To notify the team, we send a message to our Slack channel on failure. | |||
| - uses: actions/checkout@v3 # checks out the latest slack action | |||
There was a problem hiding this comment.
This checkout action has been removed because the post-run actions of the check-build action crash with out-of index if the number of steps in that action has changed since the last release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the canister_tests clean build CI job into two parts: the clean build & the hash check.
This allows to start the clean build immediately instead of just after the prod build.
Also, the clean build now really builds
the prod build from scratch, including the dev build that's hashed into it due to dfx deps (if applicable, i.e. only release builds).
Link to successful release build check run: https://github.com/dfinity/internet-identity/actions/runs/5975993428
🟡 Some screens were changed