Fix outdated outputs on release build check step #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot to update the `outputs` section of the `latest-release` release build check CI workflow. This is the fix for that. Additionally, there was a mixup between the dev and prod wasms, so I updated the naming to make it more clear as well. However, the workflow should not rely on the dev build at all. This issue will be resolved in a separate PR.
nmattia
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to update the
outputssection of thelatest-releaserelease build check CI workflow. This is the fix for that.Additionally, there was a mixup between the dev and prod wasms, so I updated the naming to make it more clear as well.
However, the workflow should not rely on the dev build at all. This issue will be resolved in a separate PR.
Link to test-run, to be sure that I actually fixed it: https://github.com/dfinity/internet-identity/actions/runs/5973919511
馃煛 Some screens were changed