Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove interface check exception #1823

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Remove interface check exception #1823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions .github/workflows/canister-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,29 +743,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
# we need the history for the tags, but we don't need the files (except for the GitHub workflows / actions)
# --> sparse checkout of only the needed things
fetch-depth: 0
sparse-checkout: |
src/internet_identity/internet_identity.did
.github
.didc-release
sparse-checkout-cone-mode: false

- name: 'Check disabled due to intentional breaking change'
id: skip-check
run: |
release="release-2023-08-11"
if [ "$(git describe --tags --match="release-[0-9-]*" HEAD --abbrev=0)" == "$release" ]; then
echo "Disabled for release $release until the next release due to intentional breaking change"
echo "interface-compatibility-disabled=true" >> "$GITHUB_OUTPUT"
else
echo "interface-compatibility-disabled=false" >> "$GITHUB_OUTPUT"
fi
- uses: ./.github/actions/setup-didc
- name: "Check canister interface compatibility"
if: steps.skip-check.outputs.interface-compatibility-disabled != 'true'
run: |
curl -sSL https://github.com/dfinity/internet-identity/releases/latest/download/internet_identity.did -o internet_identity_previous.did
didc check src/internet_identity/internet_identity.did internet_identity_previous.did