Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up close icon #1825

Merged
merged 1 commit into from Aug 28, 2023
Merged

Clean up close icon #1825

merged 1 commit into from Aug 28, 2023

Conversation

nmattia
Copy link
Collaborator

@nmattia nmattia commented Aug 25, 2023

We use a "close" (X) icon in toasts and in the dapps explorer.

The previous cross was pretty much an upper case X, which looked a bit odd. The scaling & the animating was inconsistent.

This replaces the base icon with a proper cross and makes the proportions & animations a bit nicer.

before/after/before/after:

Screen.Recording.2023-08-25.at.17.44.17.mov

We use a "close" (X) icon in toasts and in the dapps explorer.

The previous cross was pretty much an upper case X, which looked a bit
odd. The scaling & the animating was inconsistent.

This replaces the base icon with a proper cross and makes the
proportions & animations a bit nicer.
@nmattia nmattia marked this pull request as ready for review August 25, 2023 15:48
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@nmattia nmattia added this pull request to the merge queue Aug 28, 2023
Merged via the queue into main with commit 3698d88 Aug 28, 2023
48 checks passed
@nmattia nmattia deleted the nm-close-icon-cleanup branch August 28, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants