Make max number of inflight captchas configurable #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a long standing issue with a very long running integration test that maxes out a non configurable limit. It is fixed by making the limit configurabel. This is done in preparation for the API v2 registration endpoint that would also have duplicated the long running test aggravating the issue further. Fixing this issue cuts down rust integration test time by about 90 seconds. In addition, the storage tests for the persistent state are made more robust so that they no longer break on persistent state changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a long standing issue with a very long running integration test that maxes out a non configurable limit.
It is fixed by making the limit configurabel. This is done in preparation for the API v2 registration endpoint that would also have duplicated the long running test aggravating the issue further. Fixing this issue cuts down rust integration test time by about 90 seconds.
In addition, the storage tests for the persistent state are made more robust so that they no longer break on persistent state changes.