Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more toast variations #1832

Merged
merged 1 commit into from Aug 28, 2023
Merged

Add more toast variations #1832

merged 1 commit into from Aug 28, 2023

Conversation

nmattia
Copy link
Collaborator

@nmattia nmattia commented Aug 28, 2023

This restructures the toast styling implementation and adds some toast variations.

In particular, the "irregularity" classes are renamed to "toast-body" to be more accurate, and slightly modified to accomodate more toast variations.

Said variations are added (for "info" and "success" toasts), and toasts are now added to the showcase components page.

The design of "info" and "success" is not pretty, but these are currently only used in the showcase.

Screen.Recording.2023-08-28.at.15.36.32.mov

This restructures the toast styling implementation and adds some toast
variations.

In particular, the "irregularity" classes are renamed to "toast-body" to
be more accurate, and slightly modified to accomodate more toast
variations.

Said variations are added (for "info" and "success" toasts), and toasts
are now added to the showcase components page.

The design of "info" and "success" is not pretty, but these are
currently only used in the showcase.
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp

@nmattia nmattia added this pull request to the merge queue Aug 28, 2023
Merged via the queue into main with commit 8447b58 Aug 28, 2023
48 checks passed
@nmattia nmattia deleted the nm-moar-toasts branch August 28, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants