Showcase registration flow #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmattia
commented
Aug 29, 2023
| import { displayUserNumberWarmup } from "./finish"; | ||
| import { savePasskey } from "./passkey"; | ||
|
|
||
| /** Registration (anchor creation) flow for new users */ | ||
| export const registerFlow = async <T>({ |
There was a problem hiding this comment.
most of this is was just extracted from register
nmattia
commented
Aug 29, 2023
| @@ -83,17 +83,17 @@ export type LoginResult = | |||
| | NoSeedPhrase | |||
| | SeedPhraseFail | |||
| | CancelOrTimeout; | |||
| export type RegisterResult = | |||
| | LoginSuccess | |||
| export type RegisterResult<T = AuthenticatedConnection> = | |||
There was a problem hiding this comment.
these types are a mess but I don't have time to clean this up right now
This refactors the `register` function to be able to showcase the registration flow without needing to spin up a canister. A type parameter had to be added to `RegisterResult` to allow "mocking" the result without creating an actual canister connection. The flow part is extracted from `register`, which is now a wrapper around this new `registerFlow`; `register` now only deals with canister/concrete implementation details whereas `registerFlow` only focuses on the user interaction.
nmattia
force-pushed
the
nm-register-flow
branch
from
a714d80
to
35aaae7
Compare
nmattia
added a commit
that referenced
this pull request
Sep 1, 2023
This extracts the flow essence of the authenticateBox so that the flow can be showcased on `/flows/loginManage`. In practice, most canister calls were abstracted away so that the flow can be used without an actual canister. Similar to the registration flow showcased in #1836.
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
This extracts the flow essence of the authenticateBox so that the flow can be showcased on `/flows/loginManage`. In practice, most canister calls were abstracted away so that the flow can be used without an actual canister. Similar to the registration flow showcased in #1836.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the
registerfunction to be able to showcase the registration flow without needing to spin up a canister.A type parameter had to be added to
RegisterResultto allow "mocking" the result without creating an actual canister connection.The flow part is extracted from
register, which is now a wrapper around this newregisterFlow;registernow only deals with canister/concrete implementation details whereasregisterFlowonly focuses on the user interaction.🟡 Some screens were changed