Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix canister id in test app #1857

Merged
merged 1 commit into from Sep 7, 2023
Merged

Fix canister id in test app #1857

merged 1 commit into from Sep 7, 2023

Conversation

frederikrothenberger
Copy link
Member

@frederikrothenberger frederikrothenberger commented Sep 7, 2023 •
edited by github-actions bot

The test app canister id replacement mechanism broke (presumably quite a while ago). This fixes PR fixes it.

@frederikrothenberger
Fix canister id in test app
2b1357c 
The test app canister id replacement mechanism broke
(presumably quite a while ago). This fixes PR fixes it.
nmattia
nmattia approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp

@frederikrothenberger frederikrothenberger added this pull request to the merge queue Sep 7, 2023
Merged via the queue into main with commit 90e7ce2 Sep 7, 2023
49 checks passed
@frederikrothenberger frederikrothenberger deleted the frederik/fix-test-app-canister-id branch September 7, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmattia nmattia nmattia approved these changes

@peterpeterparker peterpeterparker Awaiting requested review from peterpeterparker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frederikrothenberger @nmattia