Infer issuer canisterId from origin on localhost #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For issuers hosted on `localhost` (using the a canister id as a subdomain) II will no longer make a network request to get the canister ID during the attribute sharing flow. Instead, the canister id will be parsed from the origin directly. This change makes it possible to integrate issuers with II in a local dev setup if canisterId subdomain of `localhost` is used as the issuer (derivation) origin.
| @@ -334,28 +365,28 @@ const getValidatedIssuerDerivationOrigin = async ({ | |||
| } | |||
| | { kind: "ok"; origin: string } | |||
| > => { | |||
| const result = await vcIssuer.getDerivationOrigin({ origin: issuerOrigin }); | |||
| const derivationOriginResult = await vcIssuer.getDerivationOrigin({ | |||
There was a problem hiding this comment.
I took the liberty of renaming a few variables in this function because I think it makes following the logic a bit easier.
przydatek
reviewed
Mar 14, 2024
There was a problem hiding this comment.
LGTM for the logic, thanks!
(I suppose @lmuntaner will take a look also on TS-changes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issuers hosted on
localhost(using the a canister id as a subdomain) II will no longer make a network request to get the canister ID during the attribute sharing flow. Instead, the canister id will be parsed from the origin directly.This change makes it possible to integrate issuers with II in a local dev setup if canisterId subdomain
of
localhostis used as the issuer (derivation) origin.🟡 Some screens were changed