Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom domains to use alternative origins #2399

Merged

Commits on Apr 3, 2024

  1. Allow custom domains to use alternative origins

    This PR lifts the restriction on the alternative origins feature to only
    allow canister id based subdomains of `ic0.app` and `icp0.io`.
    
    The canister id resolution is now the same for the session authorization
    flow as it is for verifiable credentials.
    
    The following restriction is still in place: the alternative origins file
    needs to be served from a canister accessible on the `icp0.io` domain.
    
    Allowances are made for local development using `localhost`, `0.0.0.0`,
    `127.0.0.1` and custom HTTP gateways.
    
    This PR also adds a unit test suite for the derivation origin validation.
    frederikrothenberger committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    db4e29b View commit details
    Browse the repository at this point in the history
  2. Improve comment

    frederikrothenberger committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    03c10cc View commit details
    Browse the repository at this point in the history
  3. Fix backticks

    frederikrothenberger committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    4bc3fc8 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    b8fe656 View commit details
    Browse the repository at this point in the history