Increase archive buffer memory limit #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR increases the memory limit for the archive buffer.
frederikrothenberger
force-pushed
the
frederik/increase-incident-memory-limit
branch
from
d8a3c99
to
660d3cf
Compare
lmuntaner
approved these changes
Apr 15, 2024
| @@ -231,7 +231,11 @@ impl<M: Memory + Clone> Storage<M> { | |||
| // A single archive entry takes on average 476 bytes of space. | |||
| // To have space for 10_000 entries (accounting for ~10% overhead) we need 82 pages or ~5 MB. | |||
| // Since the memory manager allocates memory in buckets of 128 pages, we use a full bucket here. | |||
| let archive_buffer_memory = single_bucket_memory(&memory_manager, ARCHIVE_BUFFER_MEMORY_ID); | |||
| // XX: Clean-up after incident | |||
There was a problem hiding this comment.
Did you create a Jira issue?
There was a problem hiding this comment.
Not yet. Could you create one?
There was a problem hiding this comment.
Done: https://dfinity.atlassian.net/browse/GIX-2428
I'm not sure I described the issue correctly. Feel free to change it.
frederikrothenberger
deleted the
frederik/increase-incident-memory-limit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the memory limit for the archive buffer.
🟡 Some screens were changed