Fix dapp logo showcase #2478
Merged
Fix dapp logo showcase #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wider logos:
Higher logo: |
|
The changes in the screenshots are because the logos are moved slightly to the left. I don't rely on the "left" to set the width of the container and instead I use the aspect-ratio. |
|
This logo (see screenshot) was too big before or becomes too big?
|
It was too big before. In this PR: |
|
The Juno icon becomes a bit smaller but, I allow it (for now at least 😉) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue in the home page's showcase of logos when a logo was not square and was instead a rectangle.
In this PR, I add a container to make sure the images have a square ration and the logo is contained within it.
🟡 Some screens were changed