Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iter.fromArrayMut freeze the array before iteration. #58

Open
crusso opened this issue Jun 22, 2020 · 4 comments
Open

Iter.fromArrayMut freeze the array before iteration. #58

crusso opened this issue Jun 22, 2020 · 4 comments

Comments

@crusso
Copy link
Contributor

crusso commented Jun 22, 2020 •
edited
Loading

Do we really want that inefficiency built in?@rossberg?
@rossberg
Copy link
Contributor

Sorry, I'm afraid I'm missing some context.

@kritzcreek
Copy link
Contributor

@rossberg See here: https://github.com/dfinity-lab/motoko-base/blob/44470a94d8c1d728a58cce74ff459b7213dc23f2/src/Iter.mo#L145-L150

@rossberg
Copy link
Contributor

Ah, thanks!

Yeah, I agree this seems like a very expensive semantics. Was the motivation to protect against concurrency bugs? Maybe you actually want to observe the updates in some cases?

@nomeata
Copy link
Contributor

nomeata commented Jun 23, 2020

Right. Also, it seems reasonable if this behaves like the built-in iterator (.vals())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@crusso @nomeata @rossberg @kritzcreek