example #11
Closed
example #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyan-dfinity
commented
Apr 24, 2020
| public type Comparable<T> = { | ||
| compare : (T, T) -> Order; | ||
| }; | ||
| public type t<T> = makeHeap<T>; |
There was a problem hiding this comment.
I understand type names should be capitalized, but Heap.t<Int> also looks nice.
| }; | ||
| public type t<T> = makeHeap<T>; | ||
| public class makeHeap<T>(ord : Comparable<T>) { | ||
| type t<T> = ?(Int, T, t<T>, t<T>); |
There was a problem hiding this comment.
Would be nice if I can say type t = ?(Int, T, t, t);, but it is not allowed.
| @@ -50,9 +56,10 @@ module { | |||
| case (?(_, _, a, b)) heap := merge(a,b); | |||
| } | |||
| }; | |||
| // Ideally this should be a static function. Also don't know how to return self | |||
| public func fromList(a : L.List<T>) { | |||
There was a problem hiding this comment.
Ideally this should be a static function. I can move this function out of the class, but I don't know how to return makeHeap<T> without breaking encapsulation.
| compare : (T, T) -> Order; | ||
| }; | ||
| public type t<T> = makeHeap<T>; | ||
| public class makeHeap<T>(ord : Comparable<T>) { |
There was a problem hiding this comment.
This class feels like a functor, so I use makeHeap instead of Heap. And to reference the type I defined a type synonym t above.
|
It looks like this is another instance of a Motoko developer wondering about #13 It's good to not feel alone : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.