-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs for TrieMap module #128
Conversation
They just appear unescaped as the text in the comment. Not pretty but can at least be deciphered.
They are. We'll need to come up with a referencing schema. My plan is to start with the intra-rustdoc RFC and see how far that would get us. I fear it'll involve me writing/extending an OCaml Markdown parser which I'm not excited about. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few links
Co-authored-by: Christoph Hegemann <6189397+kritzcreek@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, applied @kritzcreek comments, so will merge
Looks like @kritzcreek needs to approve again |
What's the reviewer semantics here? I'm afraid that (as usual), I may be misunderstanding some aspect of GitHub : ) For instance, is it preferable to have more reviewers for a quick review, or fewer (e.g., do they all need to re-approve every commit)? |
I followed @kritzcreek's example in HashMap.
One question for the hyperlinks: What happens when we produce non-html output?
The current links seem brittle and likely to break, right? (or link to the wrong kind of document when we generate non-html output?)