Document more of Trie module; clean up. #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
kritzcreek
suggested changes
Jul 15, 2020
|
@kritzcreek Thanks for the review. I think I addressed the most urgent issues (IIUC), PTAL when you can. |
kritzcreek
approved these changes
Jul 17, 2020
kritzcreek
added a commit
that referenced
this pull request
Jul 17, 2020
* mo-doc doc comments * update trie * replace remove2D * review fixes Co-authored-by: Christoph Hegemann <6189397+kritzcreek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revises all method/function comments to comply with mo-doc format.
@kritzcreek Unresolved issue with
mo-doc--- I found that mo-doc (from SDK 0.5.11) doesn't place internal (public) modules into the html output. So, theBuildmodule has doc comments, but they do not show up.