feat: add Result.toUpper/Result.fromUpper to facilitate interop with common IC canisters using upppercased result variants. #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusso
reviewed
Mar 17, 2024
crusso
reviewed
Mar 17, 2024
crusso
reviewed
Mar 17, 2024
crusso
reviewed
Mar 17, 2024
crusso
reviewed
Mar 17, 2024
crusso
reviewed
Apr 16, 2024
crusso
reviewed
Apr 16, 2024
crusso
changed the title
crusso
changed the title
rvanasa
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low hanging solution for https://dx.internetcomputer.org/topic/166
I found myself using this a fair amount when integrating with the new Cycles Ledger, and see it in a fair number of places that integrate with protocol canisters that were built in Rust.