Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix nix options #2880

Merged
merged 1 commit into from Nov 2, 2021
Merged

CI: fix nix options #2880

merged 1 commit into from Nov 2, 2021

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Nov 2, 2021

the install-nix-action has picked up the new nix-2.4 version, and that
needs a configuration item to enable the new nix CLI used by
nix-build-uncached.

the `install-nix-action` has picked up the new nix-2.4 version, and that
needs a configuration item to enable the new `nix` CLI used by
`nix-build-uncached`.
@github-actions
Copy link

github-actions bot commented Nov 2, 2021

Comparing from c7d0ccc to a85e011:
The produced WebAssembly code seems to be completely unchanged.

@ggreif
Copy link
Contributor

ggreif commented Nov 2, 2021

I have git cherry-pick-ed this commit to my branch and it resolved the issue there, so I guess this solution works.

@crusso
Copy link
Contributor

crusso commented Nov 2, 2021

Would it fix this https://github.com/dfinity/motoko/runs/4049327646?check_suite_focus=true?

I'll cherry-pick too to check...

@nomeata
Copy link
Collaborator Author

nomeata commented Nov 2, 2021

I have git cherry-pick-ed this commit to my branch and it resolved the issue there, so I guess this solution works.

Then maybe approve it ;-)

@nomeata nomeata added the automerge-squash When ready, merge (using squash) label Nov 2, 2021
Copy link
Contributor

@ggreif ggreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit 6bafb6f into master Nov 2, 2021
@mergify mergify bot deleted the joachim/fix-nix branch November 2, 2021 10:30
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants