Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refine capabilities #4406

Merged
merged 87 commits into from
Mar 5, 2024
Merged

feat: refine capabilities #4406

merged 87 commits into from
Mar 5, 2024

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Feb 21, 2024 •
edited

Improved capability system, introducing a synchronous (system) capability.

The actor initialisation body, pre/postupgrade hooks, async function bodies (and
blocks) possess this capability. Functions (and classes) can demand it by prepending system
to the type argument list. The capability can be forwarded in calls by mentioning <system, …>
in the instantiation parameter list.

@ggreif
WIP: add a parameter to setTimer
ceeb4d3
@ggreif
WIP: apply the error logic
c0529be
@ggreif
tweak
d7df229
@ggreif
introduce <async> type binder
e409984 
this allows us to demand that a `Local` function gets only called when a send capability is around
@ggreif
add a negative test
2f53510
ggreif
ggreif commented Feb 21, 2024
View reviewed changes
src/mo_frontend/parser.mly Outdated Show resolved Hide resolved
crusso
crusso reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising! Keep going!

ggreif
ggreif commented Feb 21, 2024
View reviewed changes
src/mo_frontend/typing.ml Outdated Show resolved Hide resolved
ggreif
ggreif commented Feb 21, 2024
View reviewed changes
test/fail/timer-no-send.mo Outdated Show resolved Hide resolved
ggreif
ggreif commented Feb 21, 2024
View reviewed changes
test/fail/timer-no-send.mo Outdated Show resolved Hide resolved
ggreif
ggreif commented Feb 21, 2024
View reviewed changes
doc/md/examples/grammar.txt Outdated Show resolved Hide resolved
@ggreif ggreif self-assigned this Feb 22, 2024
@ggreif ggreif requested a review from crusso February 22, 2024 10:17
@ggreif ggreif marked this pull request as ready for review February 22, 2024 10:18
crusso
crusso reviewed Feb 22, 2024
View reviewed changes
doc/md/examples/grammar.txt Outdated Show resolved Hide resolved
@ggreif ggreif removed the build_artifacts Upload moc binary as workflow artifacts label Mar 5, 2024
crusso
crusso reviewed Mar 5, 2024
View reviewed changes
doc/md/language-manual.md Outdated Show resolved Hide resolved
crusso
crusso reviewed Mar 5, 2024
View reviewed changes
doc/md/language-manual.md Outdated Show resolved Hide resolved
crusso
crusso approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggreif ggreif added the automerge-squash When ready, merge (using squash) label Mar 5, 2024
@mergify mergify bot merged commit c30c898 into master Mar 5, 2024
10 checks passed
@mergify mergify bot deleted the gabor/scoped-setTimer branch March 5, 2024 20:28
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luc-blaeser luc-blaeser luc-blaeser left review comments

@crusso crusso crusso approved these changes

Assignees

@ggreif ggreif

Labels
enhancement feature New feature or request typing Involves the type system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ggreif @crusso @luc-blaeser