style: extract global style to ensure build reproducibility #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubovitskaya
deleted the
style/global-style-for-build-reproducibility
branch
1 task
peterpeterparker
added a commit
that referenced
this pull request
Jan 16, 2023
# Motivation In #1666 we have moved scoped styles to global style to workaround the build reproducibility of SvelteKit+ViteJS [#8291](sveltejs/kit#8291). This PR redo the changes has #1670 will solve the reproducibility issue by removing the unused vite manifest file from our build results. # PRs - [x] #1670 # Changes - redo scoped style and remove related global style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have build reproducibility with last releases.
CI: hash a2c0186 for https://github.com/dfinity/nns-dapp/actions/runs/3764587278
Local: hash 187a34a440503da62c161e679baa02b431455c17c2b6e51bc433d63dbcae2d8f
Root cause of the issue is the build of the NNS-dapp frontend that generates different entries ("keys") in the ouputed
vite-manifest.json.Solution / Workaround
The real solution still needs to be found but to fix the reproducibitility of current state we can avoid the use of CSS mixin in favor of a global style.
If a global CSS style is used => a unique CSS is generated
If mixins are used => Svelte or Vite tries to optimize the CSS and generate a single outputed CSS for the common code. In this process it generates a file and the algorithm uses the name of the first match. Therefore we ended up with a
vite-manifest.jsoncontaining sometimesSignInCanisters.cssorSignInNeurons.cssChanges
Screenshots