Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wizard modal opening glitch #2325

Merged
merged 3 commits into from
Apr 17, 2023
Merged

fix: wizard modal opening glitch #2325

merged 3 commits into from
Apr 17, 2023

Conversation

peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Apr 17, 2023 •
edited

Motivation

Fix wizard modal opening glitch by integrating gix-cmp PR dfinity/gix-components#198

⚠️ PRs

The related PR is a tricky PR!

Changes

  • bump gix-cmp

@peterpeterparker peterpeterparker added the bug Something isn't working label Apr 17, 2023
mstrasinskis
mstrasinskis approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@peterpeterparker peterpeterparker added this pull request to the merge queue Apr 17, 2023
Merged via the queue into main with commit 9ed9814 Apr 17, 2023
28 checks passed
@peterpeterparker peterpeterparker deleted the fix/wizard-glitch-modal branch April 17, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterpeterparker @mstrasinskis