Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate the checkout #2343

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Reinstate the checkout #2343

merged 1 commit into from
Apr 19, 2023

Conversation

bitdivine
Copy link
Member

@bitdivine bitdivine commented Apr 19, 2023

Motivation

When cleaning up the commit comparison tool I managed to delete the line where the local code is checked out.

Changes

  • Check out the commit being tested before running the local docker build.

Tests

Running on a range of commits shows the repo being checked out:

$ ./scripts/nns-dapp/frontend-reproducibility-report
Previous HEAD position was 027bd72e0 E2E: Stake an SNS neuron (#2316)
HEAD is now at c01f19136 Better command line url test (#2324)
Previous HEAD position was c01f19136 Better command line url test (#2324)
HEAD is now at 38e3a55e0 fix: broken gap by tid (#2337)
Previous HEAD position was 38e3a55e0 fix: broken gap by tid (#2337)
HEAD is now at 388abdde1 Log pre-upgrade cycle count (#2335)
Previous HEAD position was 388abdde1 Log pre-upgrade cycle count (#2335)
HEAD is now at 2de7376d9 Style improvement for release candidate (#2334)
Previous HEAD position was 2de7376d9 Style improvement for release candidate (#2334)
HEAD is now at 51e4e1f48 Potential work-around for Rollup cyclic dependency bug (#2332)

@bitdivine bitdivine requested a review from dskloetd April 19, 2023 16:21
@bitdivine bitdivine added this pull request to the merge queue Apr 19, 2023
Merged via the queue into main with commit da58ef5 Apr 19, 2023
28 checks passed
@bitdivine bitdivine deleted the fix-ci-checkout branch April 19, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants