Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve mobile button long text support #944

Merged
merged 2 commits into from Jun 2, 2022
Merged

fix: improve mobile button long text support #944

merged 2 commits into from Jun 2, 2022

Conversation

mstrasinskis
Copy link
Contributor

Motivation

To have the same button height for the buttons with the long text the line-height was decreased.

Changes

  • Change A and Button default line-height to be default
  • remove redundant styles

Before

image

image

image

After

image

image

image

@mstrasinskis mstrasinskis requested a review from a team as a code owner June 2, 2022 13:44
lmuntaner
lmuntaner approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mstrasinskis mstrasinskis enabled auto-merge (squash) June 2, 2022 14:49
@mstrasinskis mstrasinskis merged commit e9c1406 into main Jun 2, 2022
@mstrasinskis mstrasinskis deleted the fix/mobile-button-height branch June 2, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

@peterpeterparker peterpeterparker Awaiting requested review from peterpeterparker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mstrasinskis @lmuntaner