Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Verifiable Credentials docs #2894

Merged
merged 25 commits into from
Jun 5, 2024
Merged

Draft: Verifiable Credentials docs #2894

merged 25 commits into from
Jun 5, 2024

Conversation

jessiemongeon1
Copy link
Contributor

Thank you for your contribution to the IC Developer Portal.
Before submitting your Pull Request, please make sure that:

lmuntaner
lmuntaner reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have a quick call to go over the flow? I believe there was a misunderstanding on what the issuer does and I'd like to understand the source of it. There must be something off in our docs.

PENDING: Review the "overview.mdx" and "relying-party.mdx"

static/img/docs/vcs-1.png Outdated Show resolved Hide resolved
submodules/internetidentity Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/how-it-works.mdx Outdated Show resolved Hide resolved
static/img/docs/vcs-2.png Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/how-it-works.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/issuer.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/issuer.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/issuer.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/issuer.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/issuer.mdx Outdated Show resolved Hide resolved
lmuntaner
lmuntaner reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review for the overview.mdx

docs/developer-docs/web-apps/verifiable-credentials/overview.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/overview.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/how-it-works.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/overview.mdx Outdated Show resolved Hide resolved
lmuntaner
lmuntaner reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for the draft!!

I believe this is enough for the first pass.

docs/developer-docs/web-apps/verifiable-credentials/issuer.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/issuer.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/issuer.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/issuer.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/issuer.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/relying-party.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/relying-party.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/relying-party.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/relying-party.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/issuer.mdx Outdated Show resolved Hide resolved
@jessiemongeon1 jessiemongeon1 marked this pull request as ready for review May 14, 2024 21:12
@jessiemongeon1 jessiemongeon1 requested a review from a team as a code owner May 14, 2024 21:12
lmuntaner
lmuntaner reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to submit some more feedback, sorry!

docs/developer-docs/web-apps/verifiable-credentials/how-it-works.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/how-it-works.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/how-it-works.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/how-it-works.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/how-it-works.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/relying-party.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/relying-party.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/relying-party.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/relying-party.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/issuer.mdx Outdated Show resolved Hide resolved
@lmuntaner
Copy link
Contributor

@kristoferlund thanks a lot for your feedback!

lmuntaner
lmuntaner reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final comments!

docs/developer-docs/web-apps/verifiable-credentials/how-it-works.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/issuer.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/overview.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/overview.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/overview.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/relying-party.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/relying-party.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/relying-party.mdx Outdated Show resolved Hide resolved
docs/developer-docs/web-apps/verifiable-credentials/relying-party.mdx Outdated Show resolved Hide resolved
static/img/docs/vcs-1.png Outdated Show resolved Hide resolved
frederikrothenberger
frederikrothenberger approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this. I like it a lot. 👍
Left a few minor comments.

docs/developer-docs/identity/verifiable-credentials/issuer.mdx Outdated Show resolved Hide resolved
docs/developer-docs/identity/verifiable-credentials/overview.mdx Show resolved Hide resolved
docs/developer-docs/identity/verifiable-credentials/relying-party.mdx Outdated Show resolved Hide resolved
docs/developer-docs/identity/verifiable-credentials/relying-party.mdx Show resolved Hide resolved
anedos-dfinity
anedos-dfinity reviewed Jun 4, 2024
View reviewed changes
docs/developer-docs/identity/verifiable-credentials/overview.mdx Show resolved Hide resolved
docs/developer-docs/identity/verifiable-credentials/overview.mdx Outdated Show resolved Hide resolved
docs/developer-docs/identity/verifiable-credentials/how-it-works.mdx Outdated Show resolved Hide resolved
docs/developer-docs/identity/verifiable-credentials/how-it-works.mdx Outdated Show resolved Hide resolved
docs/developer-docs/identity/verifiable-credentials/how-it-works.mdx Show resolved Hide resolved
docs/developer-docs/identity/verifiable-credentials/issuer.mdx Outdated Show resolved Hide resolved
docs/developer-docs/identity/verifiable-credentials/issuer.mdx Outdated Show resolved Hide resolved
docs/developer-docs/identity/verifiable-credentials/issuer.mdx Outdated Show resolved Hide resolved
docs/developer-docs/identity/verifiable-credentials/relying-party.mdx Outdated Show resolved Hide resolved
@jessiemongeon1 jessiemongeon1 merged commit 6dfdbc3 into master Jun 5, 2024
4 checks passed
@jessiemongeon1 jessiemongeon1 deleted the vc-docs branch June 5, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner left review comments

@kristoferlund kristoferlund kristoferlund left review comments

@marydwyer marydwyer marydwyer left review comments

@frederikrothenberger frederikrothenberger frederikrothenberger approved these changes

@anedos-dfinity anedos-dfinity anedos-dfinity left review comments

@dfx-json dfx-json dfx-json approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jessiemongeon1 @lmuntaner @kristoferlund @marydwyer @frederikrothenberger @dfx-json @anedos-dfinity