fix rust 1.43 lints

src/dfx/src/commands/language_service.rs

@@ -3,7 +3,6 @@ use crate::lib::environment::Environment;
 use crate::lib::error::{DfxError, DfxResult};
 use crate::lib::message::UserMessage;
 use crate::lib::package_arguments::{self, PackageArguments};
-use atty;
 use clap::{App, AppSettings, Arg, ArgMatches, SubCommand};
 use std::process::Stdio;
 

src/dfx/src/lib/builders/assets.rs

@@ -162,7 +162,7 @@ fn delete_output_directory(
         let output_assets_path = output_assets_path.canonicalize()?;
         if !output_assets_path.starts_with(info.get_workspace_root()) {
             return Err(DfxError::DirectoryIsOutsideWorkspaceRoot(
-                output_assets_path.to_path_buf(),
+                output_assets_path,
             ));
         }
         fs::remove_dir_all(output_assets_path)?;

src/dfx/src/lib/canister_info.rs

@@ -152,15 +152,13 @@ impl CanisterInfo {
             .join(PathBuf::from(&self.name))
             .join(&self.name)
             .with_extension("wasm")
-            .to_path_buf()
     }
 
     pub fn get_build_idl_path(&self) -> PathBuf {
         self.build_root
             .join(PathBuf::from(&self.name))
             .join(&self.name)
             .with_extension("did")
-            .to_path_buf()
     }
 
     pub fn get_output_wasm_path(&self) -> Option<PathBuf> {

src/dfx/src/lib/logger.rs

@@ -1,7 +1,5 @@
 use crate::config::dfx_version_str;
 use slog::{Drain, Level, Logger};
-use slog_async;
-use slog_term;
 use std::fs::File;
 use std::path::PathBuf;
 

src/dfx/src/main.rs

@@ -4,7 +4,6 @@ use crate::lib::environment::{Environment, EnvironmentImpl};
 use crate::lib::error::*;
 use crate::lib::logger::{create_root_logger, LoggingMode};
 use clap::{App, AppSettings, Arg, ArgMatches};
-use slog;
 use std::path::PathBuf;
 
 mod actors;