feat: Add --argument-file option to dfx canister sign

[Maximkaaa]

Description

dfx canister call command has an argument --argument-file to allow sending the request when argument string is too long for shell. dfx canister sign command didn't have this argument so some of the requests possible by dfx canister call were not possible to be executed through sign/send workflow. This PR fixes this unfortunate inconvenience:

• add --argument-file option to sign command
• move the logic related to reading argument string from a file from call command to utils so that it can be reused by both call and sign
• refactor the logic a little to use correct error handling instead of expects

How Has This Been Tested?

Added e2e test cases. Also did signing manually with compiled dfx, including some very long argument strings that didn't fit into CLI arguments.

Checklist:

• The title of this PR complies with Conventional Commits.
• I have edited the CHANGELOG accordingly.
• I have made corresponding changes to the documentation.

[dfinity-droid-prod]

Dear @Maximkaaa,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA¹.

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation

Footnotes

1. Contributor License Agreement ↩

[dfinity-droid-prod]

Dear @Maximkaaa,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA¹.

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation

Footnotes

1. Contributor License Agreement ↩

[sesi200]

Thank you very much for such a complete PR! Even changes to the docs are included!

I have a few small suggestions for the tests, otherwise this looks great.

[Maximkaaa]

Thanks for the quick review and suggestions. Yes, I also wanted to check the sign result in the tests but was not sure how to go about it.

[sesi200]

I'm not 100% sure this works either, but I think it should. Would you mind going through the CLA bot process? Otherwise I'm not allowed to merge this. (Also, can you do it for both issues? It has a bug where it duplicates everything and if you just go through it for both issues it opened it's quickest)

[sesi200]

This should fix the sign_send test failures

[Maximkaaa]

@sesi200 I applied the suggested change and completed cla process in both issues.

[sesi200]

Thanks a lot, @Maximkaaa. I'll only have to get #2788 merged, and then this is good to merge, too

[Maximkaaa]

I've fixed the last e2e test. The difference between expected and actual was due to the ordering of fields in the json, actual message is same.

[sesi200]

👍 then all that is left is to merge master

[Maximkaaa]

It seems that the order of fields in the response is not fixed so the tests flicker. So I changed the approach to checking the signed values. Instead of sending and checking the response, why not just check the arguments in the signed message file?

[sesi200]

That works as well. Thanks!