refactor(frontend-canister): Asset is_aliased -> enable_aliasing #3161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the name of the Asset field
is_aliased
toenable_aliasing
. Note that this does not affect the external interface.This reflects the actual meaning of the field, which may be
true
even for assets that are not actually aliased.The motivation is that I am writing an interface document for the asset canister, and the misnaming of this field makes parts of that more difficult. Also, while in the
CreateAssetArguments
the field is correctly calledenable_aliasing
, theis_aliased
naming has already propagated to theset_asset_properties
andget_asset_properties
methods. Therefore a further motivation is to discourage further propagation and to consider updating those methods in a backwards-compatible way.How Has This Been Tested?
Covered by existing tests.
Checklist: