Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend-canister): Asset is_aliased -> enable_aliasing #3161

Closed
wants to merge 1 commit into from

Conversation

ericswanson-dfinity
Copy link
Member

Description

Changes the name of the Asset field is_aliased to enable_aliasing. Note that this does not affect the external interface.

This reflects the actual meaning of the field, which may be true even for assets that are not actually aliased.

The motivation is that I am writing an interface document for the asset canister, and the misnaming of this field makes parts of that more difficult. Also, while in the CreateAssetArguments the field is correctly called enable_aliasing, the is_aliased naming has already propagated to the set_asset_properties and get_asset_properties methods. Therefore a further motivation is to discourage further propagation and to consider updating those methods in a backwards-compatible way.

How Has This Been Tested?

Covered by existing tests.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • There was no need for corresponding changes to the documentation.

@ericswanson-dfinity ericswanson-dfinity requested a review from a team as a code owner June 7, 2023 11:13
@ericswanson-dfinity ericswanson-dfinity marked this pull request as draft June 7, 2023 11:30
@ericswanson-dfinity
Copy link
Member Author

Unfortunately this will/would have to deal with upgrades

@ericswanson-dfinity ericswanson-dfinity deleted the asset-enable-aliasing branch May 6, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants