fix: [IC-272] use query call on management canister fetch_canister_logs method #3646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksymar
changed the title
maksymar
requested review from
sesi200,
ielashi,
ericswanson-dfinity and
adamspofford-dfinity
maksymar
changed the title
|
Can you add a test for this? |
…to maksym/ic-272-logs-query
Done, PTAL. |
lwshang
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The management canister method
fetch_canister_logscan only be called as a query, not an update call, so this PR fixes the issue.How Has This Been Tested?
Built and run dfx locally to verify a rust canister collects the logs and they can be retrieved by using
dfx canister logs <canister_id>.Output example:
Checklist: