Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No wigglies on https://github.dev #253

Open
ggreif opened this issue Nov 11, 2023 · 2 comments
Open

No wigglies on https://github.dev #253

ggreif opened this issue Nov 11, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@ggreif
Copy link
Contributor

ggreif commented Nov 11, 2023

  1. open https://github.dev/dfinity/motoko-base
  2. install the Motoko extension
  3. open src/Char.mo
  4. edit-in a type error
  5. observe that no wigglies appear

The other features (like go to definition) also don't seem to work.

@ggreif ggreif added the bug Something isn't working label Nov 11, 2023
@rvanasa rvanasa added enhancement New feature or request and removed bug Something isn't working labels Nov 11, 2023
@rvanasa
Copy link
Contributor

rvanasa commented Nov 11, 2023

This is known behavior. Most language support extensions are entirely unusable in github.dev (e.g. Rust, OCaml, Solidity), so we're significantly ahead of the curve in terms of browser support with syntax highlighting and formatting in the browser.

Adding type checking for web environments is a major undertaking, since we would need to create browser versions of Vessel and Mops (as well as parts of dfx) for the compiler to work as expected for any project with a dfx.json file. However, it would be possible due to using moc.js under the hood for the language server. If there's enough interest, we could certainly look into adding more features to the web version of the extension.

@ggreif
Copy link
Contributor Author

ggreif commented Nov 11, 2023

I see. Let's leave this open as a feature request. I was just naïvely expecting that it works out of the box if it installs. Ah, well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants