Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/zip2bodyfile #27

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Feature/zip2bodyfile #27

wants to merge 11 commits into from

Conversation

janstarke
Copy link
Member

add zip2bodyfile

@janstarke janstarke added the enhancement New feature or request label Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.09%. Comparing base (5b5e483) to head (7e4bca2).
Report is 4 commits behind head on main.

❗ Current head 7e4bca2 differs from pull request most recent head 0ee2646. Consider uploading reports for the commit 0ee2646 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   33.15%   33.09%   -0.06%     
==========================================
  Files          36       36              
  Lines        1137     1136       -1     
==========================================
- Hits          377      376       -1     
  Misses        760      760              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Explie Explie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janstarke I'm a little confused why the displayed modified timestamps on windows and unix archive managers are shifted for 9 hours in comparison to zip2bodyfile.

zip2bodyfile

@janstarke
Copy link
Member Author

janstarke commented Feb 29, 2024

Can you recheck this with another tool? Times are matching on my system, when using unzip and 7z

grafik

However, zip seems to be using local time instead of UTC. Hmm....

@janstarke
Copy link
Member Author

I added an integration test. Could you please provide another one which fails on your test data?

@Explie
Copy link
Member

Explie commented Feb 29, 2024

I added the failing test and test data.
What is making me curious is that the simplest change to the files within the ZIP archive leads to zip2bodyfile detecting the "correct" timestamps. Also I was not able to manually create a failing ZIP archive but the old one I had still reproduces the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants